[Solved] Turret on YT-1300 moving without my input

Any issues with the XWAU or X-Wing Alliance? Please let us know here!

Re: Turret on YT-1300 moving without my input

Bman
Lieutenant Commander
Posts: 1167
Joined: Mon Apr 05, 2004 11:01 pm

Post by Bman » Fri Jul 03, 2020 12:57 pm

Possible answer: If the turret mesh is moving around when it shouldn't look in the .ini file. If there is a [S-Foils and related landing gear section] or [Pilots] section, the wrong mesh index is being referenced. Index number tells the game which mesh to rotate assuming their transformation stats are setup correctly.
W-I-P: TFTC, MC Viscount Cr., ISD-II Avenger, NL-1 Platform, Ton-Falk Esc. Cr., & Misc.

User avatar
Ace Antilles
Admiral (Moderator)
Posts: 7829
Joined: Sat Jan 22, 2000 12:01 am
Contact:

Post by Ace Antilles » Fri Jul 03, 2020 1:04 pm

It's not an ini or an opt issue. That has been checked
Chief XWAU Team annoying nitpicker.
Ace Antilles - The X-Wing Outpost
Image

User avatar
Ace Antilles
Admiral (Moderator)
Posts: 7829
Joined: Sat Jan 22, 2000 12:01 am
Contact:

Post by Ace Antilles » Fri Jul 03, 2020 1:09 pm

Mark_Farlander wrote:
Fri Jul 03, 2020 1:11 am
Hook_Mission_Objects.cfg and Hook_Mission_Objects.dll

This hook causes the turret of the YT-1300 to slowly move without input from the player.

Without Hook_Mission_Objects.cfg and Hook_Mission_Objects.dll there is no problem with the turret.
Thanks very much for testing that. Saved me a lot of time. :)
I'll try and replicate it on my system and let the Chief Engineer know
Chief XWAU Team annoying nitpicker.
Ace Antilles - The X-Wing Outpost
Image

User avatar
JeremyaFr
XWAU Member
Posts: 3922
Joined: Mon Jan 18, 2010 5:52 pm
Contact:

Post by JeremyaFr » Fri Jul 03, 2020 1:41 pm

Hello,

I've tested with a vanilla game, without any hook, and with the patches taged as Recommended or Fix in XwaExePatcher, and disable CD check in XwaHacker.
The issue still occur.

User avatar
Mark_Farlander
Rebel Alliance
Posts: 580
Joined: Tue Jan 16, 2018 10:47 pm

Post by Mark_Farlander » Fri Jul 03, 2020 2:37 pm

I've re-tested it again: GOG v18061 X-Wing Alliance+XWAUCP v1.6
Without Hook_Mission_Objects.cfg and Hook_Mission_Objects.dll there is no problem with the turret of the YT-1300.
As soon as I put those 2 files into my X-Wing Alliance directory, the problem with the turret moving without my input (you just need to fire the first shot or even a small movement) occurs.
It seems very simple to me.

Also, I've opened the Readme of every single hook coming in that "Setup" directory of XwaHooksSetup.
The only hook that has anything to do with turrets is hook_mission_objects
Quoting the Readme:
xwa_hook_mission_objects

This hook permits to replace mission objects and to enable crafts turrets.


As for the "patches taged as Recommended" I would be curious to know which they are.
Quoting the Downloads section:
To get the full effects and be able to use all the additonal crafts you should absolutely install Jérémy's XWA Hooks.

Now may I know what's going on here?
I don't judge tactics. The Battle is the best and only Judge.

Ronin65
Cadet 3rd Class
Posts: 48
Joined: Thu Jul 02, 2020 1:00 pm

Post by Ronin65 » Fri Jul 03, 2020 3:29 pm

I agree with Mark_Farlander's findings, if you disable Hook_Mission_Objects.dll, the drifting gun turret stops, as soon as you enable the Mission Objects Hook again the drifting starts again

At first I thought maybe my joystick needed calibrating, so I calibrated it, but the same thing happens when you disable the hook, the drifting stop, when you enable the hook the drifting starts

I had better tell you, it was a vanilla install of GOG, with your latest ddraw.dll and all the latest hooks, nothing more the Xwingalliance.exe hasn't been touched, I just renamed the Hook_Mission_Objects.dll to Hook_Mission_Objects.2dll to disable it
Last edited by Ronin65 on Fri Jul 03, 2020 4:02 pm, edited 1 time in total.

User avatar
JeremyaFr
XWAU Member
Posts: 3922
Joined: Mon Jan 18, 2010 5:52 pm
Contact:

Post by JeremyaFr » Fri Jul 03, 2020 3:44 pm

I will retry.

User avatar
Phoenix Leader
Rebel Alliance
Posts: 437
Joined: Wed Aug 08, 2018 2:20 pm

Post by Phoenix Leader » Fri Jul 03, 2020 6:20 pm

JeremyaFr wrote:
Fri Jul 03, 2020 3:44 pm
I will retry.
lol, not bad for a "Chief Engineer" :lachtot:



I also have added and removed those 2 files of the Hook_Mission_Objects
Yes, they cause this issue with the turret.
When they are in my game directory the gun turret starts to move.

User avatar
JeremyaFr
XWAU Member
Posts: 3922
Joined: Mon Jan 18, 2010 5:52 pm
Contact:

Post by JeremyaFr » Fri Jul 03, 2020 7:42 pm

With a vanilla game:

When you do a large movement, there is no drift.
When you do a small movement to the right or bottom, there is no drift.
When you do a small movement to the left or the top, there is drift.

This happens in turret view, and also in cockpit or exterior views.

Ronin65
Cadet 3rd Class
Posts: 48
Joined: Thu Jul 02, 2020 1:00 pm

Post by Ronin65 » Fri Jul 03, 2020 7:59 pm

Is that with or without the Hook?

User avatar
JeremyaFr
XWAU Member
Posts: 3922
Joined: Mon Jan 18, 2010 5:52 pm
Contact:

Post by JeremyaFr » Fri Jul 03, 2020 8:41 pm

It is without the hooks.

Ronin65
Cadet 3rd Class
Posts: 48
Joined: Thu Jul 02, 2020 1:00 pm

Post by Ronin65 » Fri Jul 03, 2020 9:42 pm

Sorry but I don't get the same result, when the Hook_Mission_Objects.dll is disabled, in all three views, there is no drift, left, right, up or down the turret remains static, unless the joystick is moved

When the Hook is enabled, no matter where I move my joystick the turret drifts.

Each person that tests this might have a different result, so I'm not saying your wrong, I'm just telling you my results, Mark_Farlander may have a different result??

User avatar
Mark_Farlander
Rebel Alliance
Posts: 580
Joined: Tue Jan 16, 2018 10:47 pm

Post by Mark_Farlander » Fri Jul 03, 2020 9:47 pm

I have the same results as Ronin65
I don't judge tactics. The Battle is the best and only Judge.

korekwerner
Cadet 1st Class
Posts: 154
Joined: Wed Mar 20, 2019 7:04 pm

Post by korekwerner » Fri Jul 03, 2020 10:07 pm

@JeremyaFr, @Mark_Farlander and #Ronin65 are right. Disabling hook_mission_objects.dll disables drift inside turret.
Regards
KW

User avatar
Ace Antilles
Admiral (Moderator)
Posts: 7829
Joined: Sat Jan 22, 2000 12:01 am
Contact:

Post by Ace Antilles » Sat Jul 04, 2020 12:22 am

JeremyaFr wrote:
Fri Jul 03, 2020 3:44 pm
I will retry.
Ok here is my testing results based on the testing findings.

XWAUCP only - YT1300 - Zero uncontrolled movement in the Turret. All ok.
Hook_Mission_Objects.dll - 1.0.0.1 - 02/01/2019

XWAUCP only - YT1300 - Turret will slowly move by itself after first being moved by me.
Hook_Mission_Objects.dll - 1.0.0.1 - ‎24 ‎April ‎2020. Brand new download using Hook Setup
If I rename Hook_Mission_Objects.dll to BAK then the issue goes away. The CFG file has no different effects either way.

So something changed in the Hook_Mission_Objects.dll between the XWAUCP in 2019 and 2020 that is causing the small movement.
Hope that helps Jeremy.
Chief XWAU Team annoying nitpicker.
Ace Antilles - The X-Wing Outpost
Image

User avatar
JeremyaFr
XWAU Member
Posts: 3922
Joined: Mon Jan 18, 2010 5:52 pm
Contact:

Post by JeremyaFr » Sat Jul 04, 2020 8:41 am

@Mark_Farlander @Phoenix Leader @Ronin65 @Ace Antilles
Thanks for testing

User avatar
capitanguinea
Galactic Empire
Posts: 226
Joined: Sun Aug 30, 2015 3:59 pm

Post by capitanguinea » Sat Jul 04, 2020 9:12 am

Mark_Farlander wrote:
Fri Jul 03, 2020 9:47 pm
I have the same results as Ronin65
j

Tested, and had same results too

User avatar
JeremyaFr
XWAU Member
Posts: 3922
Joined: Mon Jan 18, 2010 5:52 pm
Contact:

Post by JeremyaFr » Sat Jul 04, 2020 1:57 pm

Strange.

I've recalibrated my joystick.

Now I get different results.
With all the hooks, there is a drift in turret when I press a button.
If I disable the joystick hook, then there is no drift.

User avatar
Forceflow
Fleet Admiral (Administrator)
Posts: 7203
Joined: Wed Oct 20, 1999 11:01 pm
Contact:

Post by Forceflow » Sat Jul 04, 2020 2:12 pm

JeremyaFr wrote:
Sat Jul 04, 2020 1:57 pm
Strange.

I've recalibrated my joystick.

Now I get different results.
With all the hooks, there is a drift in turret when I press a button.
If I disable the joystick hook, then there is no drift.
What did the hook change? Wasn't it the deadzone setting? Maybe completely removing any sort of deadzone is too much for the game?
Murphy was an optimist! I am a pessimist!
And always remember that a smile is cheaper than a bullet! (District 9)
Webmaster of the X-Wing Alliance Upgrade Project

Ronin65
Cadet 3rd Class
Posts: 48
Joined: Thu Jul 02, 2020 1:00 pm

Post by Ronin65 » Sat Jul 04, 2020 2:39 pm

OK Tested again

Vanilla GOG game
Your latest DDraw.dll and Dinput.dll
add all the Hook Cfg files as they don't alter anything

Added only the Hook_Joystick_FF.dll, result no turret drift
Removed Hook_Joystick_FF.dll result no turret drift

Added only the Hook_Mission_Objects.dll result the turret drifts
removed Hook_Mission_Objects.dll result no turret drift

Result the Hook_Mission_Objects.dll has a little problem
:D

User avatar
Mark_Farlander
Rebel Alliance
Posts: 580
Joined: Tue Jan 16, 2018 10:47 pm

Post by Mark_Farlander » Sat Jul 04, 2020 10:42 pm

Mark_Farlander wrote:
Fri Jul 03, 2020 1:36 am
Also I've noticed that in the Readme of Hook_mission_tie.dll there is no mention of the fact that the craft count limit per region is increased from 96 to 192.
Has this feature been removed?
I need it for custom made missions. Thanks
There is no mention of the value 192, but it works fine.
I don't judge tactics. The Battle is the best and only Judge.

User avatar
Mark_Farlander
Rebel Alliance
Posts: 580
Joined: Tue Jan 16, 2018 10:47 pm

Post by Mark_Farlander » Sat Jul 04, 2020 10:57 pm

Ronin65 wrote:
Sat Jul 04, 2020 2:39 pm
OK Tested again

Vanilla GOG game
Your latest DDraw.dll and Dinput.dll
add all the Hook Cfg files as they don't alter anything

Added only the Hook_Joystick_FF.dll, result no turret drift
Removed Hook_Joystick_FF.dll result no turret drift

Added only the Hook_Mission_Objects.dll result the turret drifts
removed Hook_Mission_Objects.dll result no turret drift

Result the Hook_Mission_Objects.dll has a little problem
:D
I've re-tested again and I have to totally agree with Ronin65. Also, 3 friends of mine have tested those 2 .dll as well today and they all got the same result.

If Hook_Mission_Objects.dll has caused this bug to so many users, then at least it would be a good idea to remove it from the installers of the individual crafts.
Last edited by Mark_Farlander on Sun Jul 05, 2020 9:34 am, edited 1 time in total.
I don't judge tactics. The Battle is the best and only Judge.

User avatar
Ace Antilles
Admiral (Moderator)
Posts: 7829
Joined: Sat Jan 22, 2000 12:01 am
Contact:

Post by Ace Antilles » Sat Jul 04, 2020 11:14 pm

Mark_Farlander wrote:
Sat Jul 04, 2020 10:57 pm
I've re-tested and I have to totally agree with Ronin65. Also, 3 friends of mine have tested those 2 .dll as well today and they all got the same result.

I came into contact with so many wonderful people thanks to this community and I really like to share my knowledge of the game here.
I hate to think bad things, but I'm afraid the "core members" of the community are hiding something about this hook (Hook_Mission_Objects.dll date modified: Friday, ‎April ‎24, ‎2020, ‏‎6:58:34 PM).
If it has caused this bug to so many users, then at least it would be a good idea to remove it from the installers of the individual crafts.
I'm perfectly aware that much work is being done "behind the scenes" to solve this problem, but when too many things are done "behind the scenes" I simply don't like it.
Are you trying to say there's some sort of conspiracy theory going on behind the scenes??? That's just crazy, I'm not sure where you get that idea.
Jeremy is the one that creates the Hooks. Either because he found a clever solution or based on a suggestion from ANYONE on this forum.
No one tells him to add something secret and he posts all his findings and releases in public.

I assure you no one knew about this bug before it was posted in public and the only testing done has been by the people in this thread.
Once Jeremy finds the solution then he will update it for EVERYONE to use here.
Like all hook fixes it will need to be added manually to your installation. We can't go back and update every installer when a new hook is released.

Work that is being done "behind the scenes" as you say is to come up with improved ways to install the XWAU in the future to make it simpler and prevent so many people having trouble with installation. Once that's finalised and ready then it will be released but that's a little way off.

I really don't know why you feel that the XWAU team would deliberately want to hide something when myself and Jeremy are actively working towards fixing the problem! I'm sorry if you feel that way but you're imagining things that are not there.
Chief XWAU Team annoying nitpicker.
Ace Antilles - The X-Wing Outpost
Image

User avatar
Driftwood
Admiral (Moderator)
Posts: 2174
Joined: Wed Oct 22, 2003 11:01 pm
Contact:

Post by Driftwood » Sat Jul 04, 2020 11:36 pm

Mark, it's a bug, and a really small one at that. Mission objects hook is central to a lot of functions to my understanding at this point, Jeremya can correct me if I am wrong in this assertion, so we can't "just get rid of it", it needs fixed, and you guys bringing the issue to the table helps us do that. So thank you.

Furthermore all functions of hooks, and how to use them are publicly available on the forums, when errors are discovered and things are fixed Jeremya always posts an explanation so its not as if we are withholding relevant information from the community.

Believe you me though, the stuff going on "behind the scenes" is simply not relevant to public discussion at this time or else it would be shared publicly.

Mark, just a friendly bit of advise to try and get things back on track, read the last bit of your last post and just try and see how it might rub the team members the wrong way given recent events.

User avatar
Mark_Farlander
Rebel Alliance
Posts: 580
Joined: Tue Jan 16, 2018 10:47 pm

Post by Mark_Farlander » Sun Jul 05, 2020 12:26 am

Quoting the readme of xwa_hook_mission_objects

# To call the hook that read exe crafts turrets data
At offset 059F27, replace 668B8450D0B65B00 with B83D010000909090.
At offset 061C33, replace 668B8440D2B65B00 with B83D010000909090.
At offset 09178B, replace 668B8408D2B65B00 with B83D010000909090.
At offset 096B68, replace 668BB0D2B65B00 with BE3D0100009090.
At offset 096B2A, replace 8D0450 with 909090.
At offset 096B33, replace 0FBF88C6B65B00 with 50E8E713110059.
At offset 096B3C, replace 0FBF90BEB65B00 with 50E8DE1311005A.
At offset 096B53, replace 0FBF90C2B65B00 with 50E8C71311005A.
At offset 00C9DF, replace 668B9C42D2B65B00 with BB3D010000909090.
At offset 015D77, replace 668B8440D2B65B00 with B83D010000909090.
At offset 030B3C, replace 668B8440D2B65B00 with B83D010000909090.
At offset 03EE07, replace 668B88C8B65B00668B90CCB65B00 with 5056E812911600595A9090909090.
At offset 106FAA, replace 50E88052FDFF25FFFF000083C4048D14808D0CD0 with 50E8800F0A0083C40485C00F849E010000EB2390.
At offset 0C342F, replace 6683B8D2B65B00007424EB18 with E8FC4A0E009090907424EB28.
At offset 0C34A0, replace 3B404C00 with 21404C00.
At offset 0E8E65, replace 668B8448D0B65B00 with B83D010000909090.
At offset 0EF00E, replace 668B8448D0B65B00 with B83D010000909090.
At offset 0EFC0D, replace 668B8450D0B65B00 with B83D010000909090.
There are 9 replacements that are all equal. I've underlined in blue.
Still they are not exactly equal: in this one
At offset 00C9DF, replace 668B9C42D2B65B00 with BB3D010000909090.
there is a "B" instead of "8".



Also, here both the replaced ones and the replacements are respectively equal:
At offset 0E8E65, replace 668B8448D0B65B00 with B83D010000909090.
At offset 0EF00E, replace 668B8448D0B65B00 with B83D010000909090.
I'm sorry I cannot help you more than this.
I don't judge tactics. The Battle is the best and only Judge.

Post Reply